chore(lint): enable T20 rule (no print() in library code)#1063
chore(lint): enable T20 rule (no print() in library code)#1063Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Conversation
Add T20 (flake8-print) to the select list. print() calls in library code bypass log levels and pollute stdout. T201 remains in the unfixable list to prevent silent removal of print statements. Existing violations need compliance fixes (noqa directives). Co-Authored-By: AJ Steers <aj@airbyte.io>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1783311872-ruff-enable-t20' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1783311872-ruff-enable-t20'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change modifies the Ruff linter configuration to enable the T20 (flake8-print) rule, which flags usage of print() statements in the codebase. The rule was previously commented out with a TODO note. ChangesRuff Config Update
Estimated code review effort: 1 (Trivial) | ~2 minutes PoemA single line, a rule set free, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Code Coverage OverviewLanguages: Python Python / code-coverage/pytest-fastThe overall coverage in the branch is 67%. The coverage in the branch is 65%. Show a code coverage summary of the most impacted files.
Python / code-coverage/pytest-no-credsThe overall coverage in the branch is 67%. The coverage in the branch is 65%. Show a code coverage summary of the most impacted files.
Python / code-coverage/pytestThe overall coverage in the branch is 72%. The coverage in the branch is 71%. Show a code coverage summary of the most impacted files.
Updated |
1 participant
Summary
Uncomment
T20(flake8-print) in the select list.print()calls in library code bypass log levels and pollute stdout — critical for a library consumed by downstream tools.T201remains in theunfixablelist to preventruff check --fixfrom silently deleting print statements.Existing violations will be addressed by a stacked compliance PR with
noqadirectives.Link to Devin session: https://app.devin.ai/sessions/6ae2048fc77a4f278aee3dd022384f4a
Requested by: Aaron ("AJ") Steers (@aaronsteers)
Summary by CodeRabbit
print()statements in library code.